zulip/zulip-mobile

Align message content deletion experience with web app

Open

#5,528 opened on Oct 20, 2022

View on GitHub
 (6 comments) (0 reactions) (1 assignee)JavaScript (673 forks)github user discovery
a-compose/sendhelp wantedwebapp parity

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (PR metrics pending)

Description

We should make two changes to make the mobile app message deletion experience consistent with the web app and https://zulip.com/help/edit-or-delete-a-message#delete-a-message. Specifically, we should only use "Delete message" to refer to fully removing the message, rather than deleting message content.

We should:

  • Drop the "Delete message" option from the menu for your own messages. (Once #4701 is resolved, this option will be re-added when the user has message deletion permissions.)
  • Allow users to delete all the content of a message when editing messages. In that case, the message should be shown as "(deleted)". Currently, messaging editing changes cannot be saved when the resulting message content is empty.

Contributor guide

Research direction
Investigate the message edit and delete UI components in the codebase. Understand how the web app handles deletion and the '(deleted)' placeholder. Implement removing the 'Delete message' option for own messages and allow saving empty message content to show '(deleted)'. Refer to the linked help page and issue #4701 for context.
Tech stack
javascriptreact native
Domain
mobile
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReact Native
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60