zulip/zulip-mobile

Set `queue` on accessibility announcements in OfflineNoticeProvider

Open

#5,611 opened on Dec 13, 2022

View on GitHub
 (2 comments) (0 reactions) (1 assignee)JavaScript (673 forks)github user discovery
a-a11yhelp wanted

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (PR metrics pending)

Description

This is a followup to #5344 (once that upgrade is done, as in #5610.) We have the following TODO-react-native comments in OfflineNoticeProvider.js:

      // TODO(react-native-68): Use announceForAccessibilityWithOptions to
      //   queue this behind any in-progress announcements
      AccessibilityInfo.announceForAccessibility(_('Zulip’s Internet connection is uncertain.'));
// …
      // TODO(react-native-68): Use announceForAccessibilityWithOptions to
      //   queue this behind any in-progress announcements
      AccessibilityInfo.announceForAccessibility(_('Zulip is online.'));

That's referring to this new feature in RN v0.68: https://reactnative.dev/docs/0.68/AccessibilityInfo#announceforaccessibilitywithoptions

By default announcements will interrupt any existing speech, but on iOS they can be queued behind existing speech by setting queue to true in the options object.

That would be a nice, small, polish tweak.

Contributor guide

Research direction
Replace the two `AccessibilityInfo.announceForAccessibility` calls with `AccessibilityInfo.announceForAccessibilityWithOptions` and set `queue: true` in the options object.
Tech stack
javascriptreact native
Domain
mobile
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80