wpilibsuite/allwpilib

mockdata internal classes reset functions are inconsistently virtual

Open

#4,017 opened on Feb 10, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (714 forks)auto 404
good first issueos: simulationtype: fix

Repository metrics

Stars
 (1,281 stars)
PR merge metrics
 (PR metrics pending)

Description

For example:

... I don't think any of the mockdata objects are ever inherited from (nor are they intended to be?), so it's probably best to just remove all the virtual functions? @ThadHouse might be able to provide insight to your original intent for these?

Probably best to wait until 2023 to make this change in any case.

Contributor guide

Research direction
Examine each mockdata Internal header file and remove the virtual keyword from reset functions.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75